|
|
| dloneranger |
| Posted: Feb 27 2015, 01:33 PM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
So here's the next test version so people can try out different file extensions etc against it
On the extended options screen there's a 'use' checkbox next to the priority Checked, it uses the priority and disables the signature check Unchecked, it enables the signature check so all should be the same as it used to be
It's hacky but there's nowhere to just reject a filename in the interface apart from the file extension list, and .avs was removed ages ago
v0825 beta a https://dl.dropboxusercontent.com/u/1702491...%20beta%20A.zip
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| ale5000 |
| Posted: Feb 27 2015, 08:23 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07

|
What about having both priority and signature check at the same time?
| QUOTE | return a value indicating the quality of match: -1 if the file could not be recognized, 0 if the file match is sketchy, and 1 if the match is definitive. |
Return 0 and use priority maybe is the best choice?
-------------------- New VirtualDub forum VirtualDub AIO (All-in-One installer for VirtualDub and plugins) Codec Toolbox RS (A tool to read/change merit of codecs and many other things) Input plugins for VirtualDub / ACM codecs / VFW codecs |
 |
| dloneranger |
| Posted: Feb 27 2015, 08:27 PM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
If I have the sig check then virtualdub ignores the priority
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| ale5000 |
| Posted: Feb 27 2015, 08:35 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07

|
I have edited the previous message, re-read it.
-------------------- New VirtualDub forum VirtualDub AIO (All-in-One installer for VirtualDub and plugins) Codec Toolbox RS (A tool to read/change merit of codecs and many other things) Input plugins for VirtualDub / ACM codecs / VFW codecs |
 |
| dloneranger |
| Posted: Feb 27 2015, 08:56 PM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
That's not the signature that makes the difference (The DetectBySignature call isn't used at all) It's the one in the VDXInputDriverDefinition
There's no option about using a priority, it's part of the definition of the input plugin - they all have to have one
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| ale5000 |
| Posted: Feb 28 2015, 01:48 AM |
 |
|

Advanced Member
  
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07

|
1) I don't know how it works in details but if there is a signature check in two plugins for the same format I think it use the priority otherwise how can it choose?
2) About the HKLM as fallback how it works? In Win XP x64 I see that SOFTWARE key for HKCU is shared between 32 and 64 bit instead the SOFTWARE key for HKLM is separated. So if the settings should be separated the key used by the 64-bit build in HKCU should be different, like VirtualdubFFMpegInputDriver64, instead if they should be shared maybe the 64 bit build should look in 32-bit HKLM instead of 64-bit HKLM to be consistent. But in this way it will works if both 32 and 64 bit VirtualDub are opened at the same time?
3) FFInputDriver 0.7 in the FFInputDriver.vdplugin file report version 1.7.0.1 so tools that compare version will detect your plugin as older, it would be nice if you bump from version 0.8.2.5 to version 1.8.0.0 to prevent update problems.
-------------------- New VirtualDub forum VirtualDub AIO (All-in-One installer for VirtualDub and plugins) Codec Toolbox RS (A tool to read/change merit of codecs and many other things) Input plugins for VirtualDub / ACM codecs / VFW codecs |
 |
| jpsdr |
| Posted: Feb 28 2015, 08:06 AM |
 |
|
Advanced Member
  
Group: Members
Posts: 335
Member No.: 20490
Joined: 23-December 06

|
Result for me : - Checked : avs files are handled by the VDub pluggin. - Unchecked : avs files are handled by the FFMEG pluggin.
Strange, i understood the opposite reading your description, i had misunderstood. |
 |
| dloneranger |
| Posted: Feb 28 2015, 10:55 AM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
Ah...... That would be because I've "done it the wrong way around" ™ oops
Can you hear that repetitive banging noise? That's my head on the desk that is
V0825 beta B Fixed use priority being the wrong way around https://dl.dropboxusercontent.com/u/1702491...%20beta%20B.zip
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| dloneranger |
| Posted: Feb 28 2015, 11:31 AM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
@ale5000
1) Well, I'm kind of stuck here aren't I - no matter which way I do it someone wants it the other way around So.... you get a priority and a checkbox and as that works I'm done with it
2) On a 32bit system its HKLM as usual. On a 64bit system 64bit is HKLM but 32bit processes are redirected to the Wow6432Node in \SOFTWARE No matter which way I do it, use same settings or different for 32/64 'it will be wrong' so they're going to use the same HKCU settings to stop the complaints that it was set to 'x' but now it's wrong I can't see a vast need for all the code to support different settings for 32/64bit options Your installer should easily write the HKLM values to the correct place depending on which plugin is installed - not sure what you're using, I use InnoSetup and it's simple there As the OS might not have a 32bit subsystem (win server or future OS) I'm asking for trouble by using the 32bit branch for the 64bit plugin And tbh... I'm not the one who wanted to write an installer - as they say "not my problem"
3) Sigh...... ok fine
And that's it I'm sick/done with this for a while
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| ale5000 |
| Posted: Feb 28 2015, 01:04 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07

|
2) I write the same value in both HKLM but other possbile "installers" can do it differently. I was saying it just because in the current way if the user start first the 64-bit version it get the 64-bit default for both the 32 and 64 bit build instead if it start first the 32-bit version it get the 32-bit default for both the 32 and 64 bit (in case they are different in the 2 HKLM). It isn't a great problem, it is just inconsistent. I have just reported to make you know, it is already working well with my installer.
You have done a very great work, thanks. I think we should ask phaeron for an explanation of a priority not working as intended.
-------------------- New VirtualDub forum VirtualDub AIO (All-in-One installer for VirtualDub and plugins) Codec Toolbox RS (A tool to read/change merit of codecs and many other things) Input plugins for VirtualDub / ACM codecs / VFW codecs |
 |
| jpsdr |
| Posted: Mar 1 2015, 09:59 AM |
 |
|
Advanced Member
  
Group: Members
Posts: 335
Member No.: 20490
Joined: 23-December 06

|
| QUOTE (dloneranger @ Feb 28 2015, 11:31 AM) | 1) Well, I'm kind of stuck here aren't I - no matter which way I do it someone wants it the other way around So.... you get a priority and a checkbox and as that works I'm done with it | Well, that's perfect for me. |
 |
| ale5000 |
| Posted: Mar 2 2015, 02:21 AM |
 |
|

Advanced Member
  
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07

|
The priority low/high works correctly along with fccHandler input plugins but apparently doesn't work with the internal avs handler so I think it is bugged here.
Can someone look at it?
-------------------- New VirtualDub forum VirtualDub AIO (All-in-One installer for VirtualDub and plugins) Codec Toolbox RS (A tool to read/change merit of codecs and many other things) Input plugins for VirtualDub / ACM codecs / VFW codecs |
 |
| dloneranger |
| Posted: Mar 8 2015, 10:37 AM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
(That's better, had a nice break and the foreheads' stopped hurting)
@ale5000 Only Phaeron can do a fix if there's something wrong
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| dloneranger |
| Posted: Mar 8 2015, 10:38 AM |
 |
|
Moderator
  
Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07

|
Latest version
V1.8.2.5 Download from Sourceforge 32bit and 64bit plugin
V1.8.2.5 [8 March 2015] Update ffdlls to 2.6.0 Add checkbox to enable/disable priority - with it enabled, virtualdub is giving us .avs files even though we don't want them Change version number so it's higher than a very old version that was released
-------------------- MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask Windows7/8 Codec Chooser All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3 |
 |
| ale5000 |
| Posted: Mar 9 2015, 07:51 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07

|
Thanks
-------------------- New VirtualDub forum VirtualDub AIO (All-in-One installer for VirtualDub and plugins) Codec Toolbox RS (A tool to read/change merit of codecs and many other things) Input plugins for VirtualDub / ACM codecs / VFW codecs |
 |