|
|
| ale5000 |
| Posted: Feb 28 2011, 11:48 PM |
 |
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
You need the latest test build to replicate the problem: http://forums.virtualdub.org/index.php?act...ST&f=15&t=19755
If I load an .ac3 file under Audio => Audio from other file... with "Ask for extended options after this dialog" checked it doesn't load the audio (it doesn't show any error but in the audio menu "Source audio" is still selected instead of "Audio from other file").
I don't know if the bug is in VirtualDub or in the input plugin.
FIXED (AC-3 input plugin 1.8)
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| ale5000 |
| Posted: Dec 12 2011, 05:53 PM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
The same bug has been recently fixed for WAV import.
There is still the problem with the AC3 input plugin.
FIXED (AC-3 input plugin 1.8)
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| fccHandler |
| Posted: Dec 17 2011, 08:18 PM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
The problem seems to be a change in VirtualDub's project.cpp, line 1304. He is throwing a user abort error when the options pointer comes back NULL.
My response to the PromptForOptions API call is based on the avi.cpp sample code which comes with the Plugin SDK 1.1. There, he explicitly sets the pointer to NULL and returns false, presumably to indicate that he doesn't support extended open options. My AC3 plugin does the same.
The return value (true/false) from the API call doesn't appear to be checked, and from what I see the pointer is already NULL when I receive it, so it seems there is nothing I can do from my end to prevent the user abort error.
Interestingly, the Plugin SDK doesn't actually say that we have the ability to NOT support extended open options, so Avery could justifiably argue that they are now required. Hmm...
--------------------
May the FOURCC be with you... |
|
| phaeron |
| Posted: Dec 19 2011, 06:20 PM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
This was a limitation in the internal API -- there was no way for the plugin to signal that options aren't supported, so the only choices were to return a struct or return user cancellation. The plugin API is the same, as an options struct has to be returned if and only if the function returns true. I had to add a flag to the internal API to fix this, which I need to reflect out to the plugin API.
Update:
I just added support for this to 1.10.1-test19. The new flag is kFlagNoOptions = 4 in VDXInputDriverDefinition::mFlags and the input plugin API has been bumped to V4.
This post has been edited by phaeron on Dec 19 2011, 10:32 PM |
|
| fccHandler |
| Posted: Dec 22 2011, 03:56 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
The latest version 1.8 of the AC3 file input plugin sets the kFlagNoOptions bit:
http://fcchandler.home.comcast.net/Plugins/AC3
But I think I will wait for a new Plugin SDK before updating my other plugins, since there are probably other things that will need to be updated (like new colorspaces).
--------------------
May the FOURCC be with you... |
|
