|
|
| fccHandler |
| Posted: Mar 5 2011, 06:35 PM |
 |
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
I've added support for uncompressed PCM and HE AAC v2, and fixed some cosmetic issues:
http://fcchandler.home.comcast.net/Plugins/Matroska
But to rant, I am not happy about the way HE AAC v2 was muxed in the AAC_test.mka file uploaded by ale5000. There is no metadata in the Matroska headers or the audio private data which enables me to detect Parametric Stereo, and I have had to settle for an ugly hack to make it work. For now I consider the code experimental.
--------------------
May the FOURCC be with you... |
|
| BugMaster |
| Posted: Mar 6 2011, 01:03 AM |
|
|
Advanced Member
Group: Members
Posts: 50
Member No.: 23001
Joined: 6-February 08
|
fccHandler
You added zero_byte to 3-byte startcodes only for SPS/PPS but H.264 specs says (B.1.2 Byte stream NAL unit semantics):
zero_byte is a single byte equal to 0x00.
When any of the following conditions are fulfilled, the zero_byte syntax element shall be present:
– the nal_unit_type within the nal_unit( ) is equal to 7 (sequence parameter set) or 8 (picture parameter set),
– the byte stream NAL unit syntax structure contains the first NAL unit of an access unit in decoding order, as specified by subclause 7.4.1.2.3.
So first NAL in every frame must start from 4-byte sequence 0x00, 0x00, 0x00, 0x01 (so in UnwrapAVCFrame also). For you it probably would be less work to change all of them to 4-byte (not only first).
P.S. If you don't have H.264 specs you can freely get them here: http://www.itu.int/rec/T-REC-H.264-201003-I/en |
|
| ale5000 |
| Posted: Mar 6 2011, 01:44 AM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
| QUOTE (fccHandler @ Mar 5 2011, 07:35 PM) | | But to rant, I am not happy about the way HE AAC v2 was muxed in the AAC_test.mka file uploaded by ale5000. There is no metadata in the Matroska headers or the audio private data which enables me to detect Parametric Stereo, and I have had to settle for an ugly hack to make it work. For now I consider the code experimental. |
I know it isn't good but this is the so called "implicit detection" that pratically mean that the header doesn't know and you must parse the aac stream directly.
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| fccHandler |
| Posted: Mar 6 2011, 02:20 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
Thank you for pointing me to the spec! In fact I did not have it and didn't realize it was free. And you're right, I did overlook the UnwrapAVCFrame function. I will fix it in the next release.
--------------------
May the FOURCC be with you... |
|
| fccHandler |
| Posted: Mar 6 2011, 02:24 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
| QUOTE (ale5000 @ Mar 5 2011, 09:44 PM) | | I know it isn't good but this is the so called "implicit detection" that pratically mean that the header doesn't know and you must parse the aac stream directly. |
That is exactly why I'm unhappy about it. In my opinion the audio channel configuration should be specified somewhere in the container so I don't have to go digging through the raw audio data to get this info.
HE-AACv2 Test.mka does have the PS flag specified in its AudioSpecificConfig (codec private data), which is exactly where it should be. The AAC_Test.mka is missing this information. I don't have the real AAC spec so I'm not 100% sure whether it is a violation or not.
--------------------
May the FOURCC be with you... |
|
| ale5000 |
| Posted: Mar 6 2011, 03:06 AM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
Edit: Problem fixed
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| ale5000 |
| Posted: Mar 6 2011, 03:50 AM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
Edit: Post removed
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| fccHandler |
| Posted: Mar 6 2011, 04:52 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
| QUOTE (ale5000 @ Mar 5 2011, 11:06 PM) | | When I click again on the right arrow the text "Stream x of x" disappear. |
Good catch. I will fix this in the next release.
| QUOTE | When you open an "audio only" matroska file you cannot direct stream copy the "NO VIDEO" video.
It would be nice to don't waste time on compressing the "NO VIDEO" video and just direct stream copy a very small dummy video. |
Implementing direct stream copy of the dummy video is far more difficult than it sounds, and I can't imagine any reason that anyone would want to do that. Sorry, I am going to decline this request.
--------------------
May the FOURCC be with you... |
|
| ale5000 |
| Posted: Mar 6 2011, 05:20 AM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
| QUOTE (fccHandler @ Mar 6 2011, 05:52 AM) | | Implementing direct stream copy of the dummy video is far more difficult than it sounds, and I can't imagine any reason that anyone would want to do that. Sorry, I am going to decline this request. |
The reason is just to use VirtualDub to edit "audio only" files, but I still can do in other ways so it isn't a big problem.
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| ale5000 |
| Posted: Mar 6 2011, 10:54 PM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
For the following I haven't verified but it is highly probable:
1) The problem of 3-byte startcodes in H.264 and the fourcc missing in "File informations..." with x264vfw codec could possibly happen also with the FLV and WMV plugins.
2) The problem of "Stream 1 of 1" without audio tracks or dissappearing "Stream x of x" could possibly happen also with the MPEG2 plugin.
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| fccHandler |
| Posted: Mar 12 2011, 06:38 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
Wow, that is a great test case! 23 audio streams. Thank you for uploading it.
As originally designed, the WMV plugin File Information dialog only displays the information for the currently selected audio stream. This was an ugly hack from the old days. I will update its dialog to behave like my other plugins.
--------------------
May the FOURCC be with you... |
|
| fccHandler |
| Posted: Mar 13 2011, 06:21 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
Updated WMV plugin 2.5, now displays information for all audio tracks, plus audio language information if available:
http://fcchandler.home.comcast.net/Plugins/WMV
I do plan to implement a similar display of audio language information in the Matroska plugin, when I get time.
--------------------
May the FOURCC be with you... |
|
| fccHandler |
| Posted: Mar 19 2011, 04:14 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
Version 2.6 of the Matroska plugin is available:
http://fcchandler.home.comcast.net/Plugins/Matroska
--------------------
May the FOURCC be with you... |
|
| ale5000 |
| Posted: Mar 20 2011, 04:43 AM |
|
|
Advanced Member
Group: Members
Posts: 1114
Member No.: 22180
Joined: 30-September 07
|
Edit: Problem fixed
--------------------
New VirtualDub forum
VirtualDub AIO (All-in-One installer for VirtualDub and plugins)
Codec Toolbox RS (A tool to read/change merit of codecs and many other things)
Input plugins for VirtualDub / ACM codecs / VFW codecs |
|
| fccHandler |
| Posted: Mar 20 2011, 05:05 AM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
The File Information dialog means exactly what it says; no language was specified. I have never heard anyone claim that the default Matroska language is English. Can you point me to a link to verify this?
--------------------
May the FOURCC be with you... |
|
