|
|
| i4004 |
| Posted: Aug 5 2005, 02:11 PM |
 |
|
Advanced Member
Group: Members
Posts: 2432
Member No.: 4935
Joined: 24-June 03
|
http://i4004.net/i4004/verg_editor/1.png
800x600 with 'large' fonts.
also, i tried to load a multisegment mpeg4 cap; i just couldn't wait for it to load, i'm afraid.
i didn't tried loading of different framerate clips; simillar to don, i don't have the need for that.
--------------------------------------------
huhmm...who was naughty and used 'Vulgar Slang' in this thread?
gentle gentleman, behave yourself.
fcc:
| QUOTE | | Intel® Pentium® 4 CPU 2.80GHz' |
where did this came from, then?
--------------------
my signature:
 |
|
| Verg |
| Posted: Aug 5 2005, 03:13 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
I sincerely thank you folks for taking the time.
phaeron & fccHandler:
Thanks for those logs... nothing appears unusual, but it gives me a starting point toward figuring out what went wrong... between the "dwScale incompatible" message and the "[FAILURE] Clips not joined" message, there aren't too many lines of code. I should be able to figure out what's what\
One question though: Did the scaling dialog pop up for either of you? That would explain things a bit better:
http://www.xverg.com/timeline14.gif
i4004:
Sorry man UI hasn't been the focus at all... mostly because UI (to this point) has needed hard-coded values for window/widget positions, widths, heights, etc. I wanted to create a more flexible system of UI (perhaps XML based) that would dictate rules for widget placement and size. Hadn't come up with anything in the past, but now that I'm on to policy classes and template specialization, I can probably work out a better UI... at least something that displays the data in an unoffending manner
Much obliged, guys. Your feedback is invaluable to me. I'll see what I can do to help contribute around here toward VDub/VDubMPEG or at least answering some questions for n00bs. Don't want to become a drain.
Chad |
|
| Verg |
| Posted: Aug 5 2005, 04:24 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
OKAY...
Tracing this "no join" bug comes up with this relevant code:
| CODE | inside "_timelineJoinSelections()"
if(!_timelineSelectionsCompatibleWith(_movie))
if(!_scaleSelectedMovies()) return false; // this pops up the dialog!
std::pair<bool,MSTimeline::timeline_movie_ptr_type> joined = _joinedTimelineSelections();
if(!joined.first) return false;
...............
inside "_joinedTimelineSelections()"
if(!movie->append(*(*amovie)))
joined = false;
...............
Movie::append calls MovieEditor::join()
...............
inside "MovieEditor::join()"
VideoStream *firstvideostream = _videoStreamFrom(movie);
VideoStream *secondvideostream = _videoStreamFrom(another);
if(!firstvideostream || !secondvideostream) return Error::set("Video Stream missing from one of the movies to be joined",__FILE__,__LINE__);
if(!firstvideostream->join(*secondvideostream)) return false;
...............
inside "VideoStream::join()"
PAVISTREAM editstream = _connect(another); // another == another VideoStream
if(!editstream) return false;
...............
inside "_connect()"
PAVISTREAM editablestream = 0,
streamone = (PAVISTREAM)(_stream->id()),
streamtwo = (PAVISTREAM)(source.id());
LONG samples = source.length(),
position = (atPosition == -1) ? _stream->length() : atPosition; //streamlength = dest.length(),
HRESULT hres = ::CreateEditableStream(&editablestream,streamone);
if(AVIERR_OK != hres) { Error::set(AVILibrary::errorString(hres),__FILE__,__LINE__); return 0; }
hres = ::EditStreamPaste(editablestream,&position,&samples,streamtwo,0,-1);
if(AVIERR_OK != hres)
{
Error::set(AVILibrary::errorString(hres),__FILE__,__LINE__);
editablestream->Release();
return 0;
}
|
This leads me to believe that either CreateEditableStream, or EditStreamPaste are failing, but returning an unrecognized error code.
AVILibrary::errorString() recognizes all errors between the range AVIERR_OK and AVIERR_ERROR, as well as REGDB_E_CLASSNOTREG...
If AVILibrary::errorString() doesn't have a corresponding string for an error code, it returns a null string... which could explain why there may be an error, but no log of it.
I've modified the code to return an integer for unrecognized errors, now... it will be available in the next build (2.20?)
....
But all this is moot if the "Scale Dialog" isn't popping up. If the scale dialog isn't popping up, that's an easier problem to fix.
Chad
|
|
| Verg |
| Posted: Aug 5 2005, 06:04 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
FIXED
Fellas, I think I have Avery's and fccHandler's issue worked out
I created two Huffyuv files with differing frame rates, and reproduced the problem...
ISSUE #2...
http://www.xverg.com/develop-7.html
Seems some of the code hadn't been fixed eliminate the assumption of dwRate == 1000000...
here's the offending code:
| CODE |
if((scale < (_infoOne.dwScale/2)) || (scale > (_infoOne.dwScale*2))) return false;
|
This happens right before a call to EditStreamSetInfo, which changes the video scale and rate.
It was only checking the scale, and not returning an error... just false.
What if the scale was 4 in one clip, but 40 in another clip?
Shouldn't be a problem if clip one has a rate of 100 and
clip two has a rate of 1000, right?
Fixed it by determining the final and source framerates,
as doubles... and checking them... and now, it returns
an error instead of just "false".
Changed the code:
| CODE |
double destframerate = (double)rate/(double)scale,
sourceframerate = (double)_infoOne.dwRate/(double)_infoOne.dwScale;
if((destframerate < (sourceframerate/2)) || (destframerate > (sourceframerate*2)))
return Error::set("Too large of a frame rate change; frame rate can't be greater than double, or less than half the original frame rate",__FILE__,__LINE__);
|
Hopefully this resolves the issue for both Huffyuv and DivX
files... as well as all others...
Build 2.20 fixes that...
http://www.xverg.com/download.html |
|
| fccHandler |
| Posted: Aug 5 2005, 08:54 PM |
|
|
Administrator n00b
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02
|
| QUOTE (i4004 @ Aug 5 2005, 10:11 AM) | fcc:
| QUOTE | | Intel® Pentium® 4 CPU 2.80GHz' |
where did this came from, then?
|
You don't think I'm making all these DVDs with my old P3 600? 
Did you notice phaeron running his desktop at 1920 x 1200? My monitor won't even go that high. Even if it did, my eyesight is so poor I couldn't read it. 
--------------------
May the FOURCC be with you... |
|
| i4004 |
| Posted: Aug 5 2005, 10:13 PM |
|
|
Advanced Member
Group: Members
Posts: 2432
Member No.: 4935
Joined: 24-June 03
|
| QUOTE | | Did you notice phaeron running his desktop at 1920 x 1200? |
yes, i did.
it is his problem.
(i guess laptop stays closer to the eyes, so he finds it usable).
my next display will be 17" lcd (or even 19" if prices fall enuff by that time), but untill then, this will do.
(that reminds me, i should keep it on for longer periods of time...that way i'll buy lcd sooner... )
--------------------
my signature:
|
|
| phaeron |
| Posted: Aug 6 2005, 03:36 AM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
I don't regret my choice of wide-uber-XGA display.
Verg:
dwRate/dwScale is a fraction, so you will want to be careful when handling it. In particular, the dwScale*2 expression you had before could overflow. For fun, generate an AVI at 1 fps and set dwRate/dwScale to FFFFFFFF. |
|
| Verg |
| Posted: Aug 6 2005, 03:34 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
| QUOTE (phaeron @ Aug 5 2005, 09:36 PM) | I don't regret my choice of wide-uber-XGA display.
Verg:
dwRate/dwScale is a fraction, so you will want to be careful when handling it. In particular, the dwScale*2 expression you had before could overflow. For fun, generate an AVI at 1 fps and set dwRate/dwScale to FFFFFFFF. |
Good point. Yeah, division by zero is accounted for.... and there should be no overflow concerns now.... dwScale & dwRate are used in tandem now everywhere in the code.
BTW the new build joins DivX 5.2.1 & Huffyuv 2.1.1 files of different framerates... at least on my setup.
Thanks again Avery.
C
|
|
| jazzzy786 |
| Posted: Aug 12 2005, 10:52 PM |
|
|
Advanced Member
Group: Members
Posts: 105
Member No.: 12723
Joined: 14-November 04
|
There is a use for this program I have sometimes downloaded 2 cd movies with cd 1 at a framerate of 29.97 and cd2 at 29.975. Try joining that with vdub. Not sure what it'll do to the audio once joined though probably skew it. If you can fix the audio problem then it'll be a very useful addition to anybody's encoding tools folder. |
|
| Verg |
| Posted: Aug 16 2005, 08:49 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
| QUOTE (jazzzy786 @ Aug 12 2005, 04:52 PM) | | There is a use for this program I have sometimes downloaded 2 cd movies with cd 1 at a framerate of 29.97 and cd2 at 29.975. Try joining that with vdub. Not sure what it'll do to the audio once joined though probably skew it. If you can fix the audio problem then it'll be a very useful addition to anybody's encoding tools folder. |
What sort of audio problem are you having? Is it doing something strange to the audio once the clips are joined?
Or are you talking about something different? Joined avi clips should be able to be saved as one movie clip.
|
|
| Verg |
| Posted: Aug 18 2005, 08:38 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
Version 2.21 is now available for testing.
www.xverg.com
Changes:
-Most (all?) RGB/YUY2 based codecs should be supported now. Xvid/Divx 5.2.1 supported.
-GDI issues (flickering) about 98% taken care of. The only flickering issue now is with selected timeline clips... each thumbnail is its own object, which draws itself upon a "paint" update. They don't (yet) get the update region from their parent window. When that is done, there will be no flicker.
-XP Visual Styles (themes) activated; UI is still fairly ugly, but useable. Window Layout is a priority... will create a full-size preview window with controls soon... app will probably end up being skinned, and XP Visual Styles will be dropped at some point.
Fairly solid build. As stated before, the issue with joining clips brought up by Avery should be taken care of.
Thanks.
Chad |
|
| phaeron |
| Posted: Aug 19 2005, 03:46 AM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
Mind not reopening threads that are more than a month old in order to spam your program? You've done this six times today. Do it again, and at the very least I delete all of the posts on sight.
|
|
| Verg |
| Posted: Aug 19 2005, 05:05 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
Thanks to all who downloaded the program and gave feedback to this point. Your time was/is appreciated. I'll add one more post to this thread with a link to a Verge bbs as soon as it is set up. This shouldn't be on Avery's board. Thanks for your patience.
|
|
| Verg |
| Posted: Aug 23 2005, 06:23 PM |
|
|
Advanced Member
Group: Members
Posts: 107
Member No.: 10273
Joined: 15-May 04
|
I expect this will be the final post I make in this thread... all discussions about Verge VME should please now move to this url:
http://forums.xverg.com/index.php
This thread shouldn't be going against Avery's MB/month transfer limit... and I thank him for allowing this discussion at all.
Thanks again for all your support.
Chad
|
|
| Damnation |
| Posted: Sep 7 2005, 10:35 AM |
|
|
Unregistered
|
heya, i tested your program today trying to join 2 700mb avi files, but when i go to file > open. and select the file. the program crashes. i use xp sp2 |
|
