|
|
| fccHandler |
| Posted: Feb 18 2012, 08:44 PM |
 |
|
Administrator n00b
  
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02

|
Apparently the crash condition arises when all of the following are true:
- Color depth "AutoSelect" is configured (either explicitly or implicitly)
- You are using VirtualDub 1.9.11 or earlier
- You are opening a 4:2:0 MPEG-2 movie
Version 4.2 of the plugin returns the Rec. 709 version of the 4:2:0 colorspace in this case, which is WRONG because VirtualDub 1.9.11 doesn't know that colorspace. I have changed it to return kPixFormat_YUV420_Planar for backward compatibility. I expect this will fix the crashes:
http://fcchandler.home.comcast.net/Plugins/MPEG2
-------------------- May the FOURCC be with you... |
 |
| heustess |
| Posted: Feb 18 2012, 10:22 PM |
 |
|
Advanced Member
  
Group: Members
Posts: 67
Member No.: 21872
Joined: 5-August 07

|
4.3 works for me in 1.9.11 and 1.10.1 in Windows 7. Good work!
-------------------- http://heustess.com/ |
 |
| jman |
| Posted: Feb 19 2012, 06:47 PM |
 |
|
Member
 
Group: Members
Posts: 12
Member No.: 34123
Joined: 26-January 12

|
Yes, the 4.3 is working perfectly.  Thank you very much fccHandler for fixing the problem and thank you heustess for the contribution. Keep up the good work! |
 |
| heustess |
| Posted: Feb 19 2012, 07:25 PM |
 |
|
Advanced Member
  
Group: Members
Posts: 67
Member No.: 21872
Joined: 5-August 07

|
I just tested the plugin (something that anyone can do) under different situations. All the credit for creating and fixing the plugin goes to fccHandler.
-------------------- http://heustess.com/ |
 |
| ^rooker |
| Posted: Feb 20 2012, 05:33 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 36
Member No.: 20823
Joined: 7-February 07

|
Unfortunately, v4.3 introduces ugly artifacts with some MPEGs (created with mencoder):
I've created 2 screenshots from the same MPEG source, with VirtualDub v1.9.11 and fcchandler's plugin v4.1 and v4.2: (Sorry for the size, but I thought I'd keep the images as original/untouched as possible...)
MPEG2 plugin v4.1:

MPEG2 plugin v4.3:

This applies to both: 32bit and 64bit |
 |
| jman |
| Posted: Feb 21 2012, 01:52 PM |
 |
|
Member
 
Group: Members
Posts: 12
Member No.: 34123
Joined: 26-January 12

|
I have converted your MPEG sample to an XviD avi file with the plugin 4.1 & 4.3. The two avi files are identical (same CRC32) and contains no artifacts. Interesting... |
 |
| ^rooker |
| Posted: Feb 21 2012, 04:32 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 36
Member No.: 20823
Joined: 7-February 07

|
@jman: The artifacts shown in the images appear while playing the MPEG in VirtualDub (or if stepping through, frame-by-frame) If they are not visible on your setup, what could I check to see where they come from on my setup?
...or what has changed between v4.1 and v4.3 - because v4.1 works fine here.
Thanks for any hints! |
 |
| jman |
| Posted: Feb 21 2012, 08:00 PM |
 |
|
Member
 
Group: Members
Posts: 12
Member No.: 34123
Joined: 26-January 12

|
So only affects playback? You may try to encode the video to other format. Let's see if affects encoding too. I couldn't notice any artifact during playback or advancing by one frame in VD.  Maybe fccHandler or someone else will have a hunch. |
 |
| ^rooker |
| Posted: Feb 23 2012, 02:40 PM |
 |
|

Advanced Member
  
Group: Members
Posts: 36
Member No.: 20823
Joined: 7-February 07

|
I've exported the video to FFv1 (lossless) using ffdshow-tryouts codec plugin: Same artefacts in the resulting AVI.
Puzzling that with same fccHandler version + same VirtualDub version (1.9.11), you're not getting these artifacts...
I know I've said that it applies to 32+64bit, but right now, it only happens with the 64bit version. Maybe it was my mistake the first time, because I had multiple VirtualDubs open... 
However, with 64bit the artifacts appear during playback and export. |
 |
| fccHandler |
| Posted: Feb 24 2012, 01:09 AM |
 |
|
Administrator n00b
  
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02

|
I was not able to reproduce this with the 32-bit plugin, but I have found one serious bug in the 64-bit code, and that bug would definitely cause artifacts. I am currently going over the rest of the 64-bit code with a fine-toothed comb to see if there are any other unpleasant surprises. Stay tuned...
-------------------- May the FOURCC be with you... |
 |
| fccHandler |
| Posted: Feb 25 2012, 02:54 AM |
 |
|
Administrator n00b
  
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02

|
I fixed the decoding error in the 64-bit build. I made no changes to the 32-bit build, but I incremented its version number anyway for consistency:
http://fcchandler.home.comcast.net/Plugins/MPEG2
-------------------- May the FOURCC be with you... |
 |
| Gral |
| Posted: Feb 25 2012, 03:30 AM |
 |
|

Advanced Member
  
Group: Members
Posts: 125
Member No.: 11018
Joined: 11-July 04

|
A very small typo on the page:
"This page was last updated February 26, 2012." ???
Tomorrow?

EDIT: For me it's tomorrow, for you even day after... |
 |
| fccHandler |
| Posted: Feb 25 2012, 05:52 AM |
 |
|
Administrator n00b
  
Group: Moderators
Posts: 3961
Member No.: 280
Joined: 13-September 02

|
Good catch, thanks. The web pages are fixed now.
-------------------- May the FOURCC be with you... |
 |
| ^rooker |
Posted: Feb 27 2012, 08:48 AM |
 |
|

Advanced Member
  
Group: Members
Posts: 36
Member No.: 20823
Joined: 7-February 07

|
Wow, that was fast!
I've tried v4.4 with 64bit and the artifacts are gone. Everything's fine now. Thank you very much! |
 |