Welcome Guest ( Log In | Register )


Important

The forums will be closing permanently the weekend of March 15th. Please see the notice in the announcements forum for details.

 
F_itvc.c Code Question
« Next Oldest | Next Newest » Track this topic | Email this topic | Print this topic
dloneranger
Posted: May 1 2011, 08:03 PM


Moderator


Group: Moderators
Posts: 2366
Member No.: 22158
Joined: 26-September 07



In the Run routine there's 2 lines of code that seem odd
CODE
 // The raw scores we have are the amount of improvement we get at that frame from
 // shifting the opposite field back one frame.
 //
 // Polarity == true means TFF field order.

 sint64 pscores[5][2];
 for(int i=0; i<5; ++i) {
  pscores[i][0] = scores[i+1].mVarShift[0] + 0*scores[i+2].mVarShift[0] - scores[i+1].mVar[0] - scores[i+2].mVar[0]
      + scores[i+6].mVarShift[0] + 0*scores[i+7].mVarShift[0] - scores[i+6].mVar[0] - scores[i+7].mVar[0];
  pscores[i][1] = scores[i+1].mVarShift[1] + 0*scores[i+2].mVarShift[1] - scores[i+1].mVar[1] - scores[i+2].mVar[1]
      + scores[i+6].mVarShift[1] + 0*scores[i+7].mVarShift[1] - scores[i+6].mVar[1] - scores[i+7].mVar[1];


There's 4 multiply by 0 bits in there?
Are they bugs, typos or self documenting null-ops?



--------------------
MultiAdjust JoinWav WavNormalize FFMPeg Input Plugin v1827 UnSharpMask
Windows7/8 Codec Chooser
All FccHandlers Stuff inc. Installers for acm codecs AAC, AC3, LameMp3
 
    Top
phaeron
Posted: May 7 2011, 10:14 PM


Virtualdub Developer


Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02



Just some leftovers, I think -- those values aren't supposed to be included.
 
    Top
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:
1 replies since May 1 2011, 08:03 PM Track this topic | Email this topic | Print this topic

<< Back to Testing / Bug Reports