|
|
| Barough |
| Posted: Dec 29 2007, 11:51 AM |
 |
|
Advanced Member
Group: Members
Posts: 95
Member No.: 22677
Joined: 24-December 07
|
Just did a couple of quick tests and muxing a xvid video with a CBR MP3 stream works just gr8. No issues @ all. But muxing a xvid video with VBR MP3 stream doesn't work. The result is that the audio sounds like crap. The original audio stream is just fine.
[EDIT]
Doesn't make any different if i use the Auto function or setting if it to VBR manually in the dialog
--------------------
 |
|
| phaeron |
| Posted: Dec 29 2007, 09:44 PM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
Do you have any details on the source MP3, or a sample I can check?
|
|
| Barough |
| Posted: Dec 29 2007, 09:47 PM |
|
|
Advanced Member
Group: Members
Posts: 95
Member No.: 22677
Joined: 24-December 07
|
| QUOTE (phaeron @ Dec 29 2007, 10:44 PM) | | Do you have any details on the source MP3, or a sample I can check? |
I can upload the file to FileFactory 4 ya
[EDIT]
Here's the VBR MP3 file
http://www.filefactory.com/file/670ebc/
Also when muxing in a VBR stream so is there no audio value size in the Status Window
--------------------
|
|
| phaeron |
| Posted: Dec 30 2007, 09:32 PM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
Alright, I muxed in the mp3 file with test-8, and the only thing I saw that went wrong is stuttering during preview with audio in direct mode. Full processing mode works OK. I don't see what's wrong here, besides the preview stuttering. What exactly were you seeing?
|
|
| Barough |
| Posted: Dec 30 2007, 11:03 PM |
|
|
Advanced Member
Group: Members
Posts: 95
Member No.: 22677
Joined: 24-December 07
|
It seems like it's the latest VLC that dont like this file for some reason. VLC have worked just fine here without any issues earlier. This file plays perfectly in the latest Media Player Classic and Gom Player.
In VLC so did the audio stutter the whole time when i tried the file that have the VBR MP3 audio stream. The other file that have a CBR MP3 audio stream plays perfectly.
Both these files was created through Direct Stream Copy.
[EDIT-1]
I just muxed the 'problematic' files in VDubMod & AVI-Mux GUI and the output file in both cases plays perfectly in VLC. Will prepare another set of files and test 'em in Test 8
[EDIT-2]
Gave the new set of file the same procedure and the result was exactly the same.
CBR Mux
Audio Size is displayed in the Status Window
VBR Mux
Audio Size is NOT displayed in the Status Window
In my opinion so is something weird going with v1.7.x when muxing in a VBR MP3 stream
--------------------
|
|
| pintcat |
| Posted: Dec 31 2007, 12:36 AM |
|
|
Advanced Member
Group: Members
Posts: 142
Member No.: 18182
Joined: 19-February 06
|
I've checked VDub 1.7.X-test8 a bit (thank you so much for this one!) and found a little odd behavior in the cropping mode: When I try to crop a picture (no matter which filter I use or which type of video is loaded), the cropping bars don't remove parts of the picture, but they resize it in the particular direction. After closing the cropping and filter window the frame remains at the same size as before, but the picture is completely deformed!
|
|
| phaeron |
| Posted: Dec 31 2007, 09:18 AM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
http://www.virtualdub.org/beta/VirtualDub-...1.7.X-test9.zip
http://www.virtualdub.org/beta/VirtualDub-...test9-AMD64.zip
http://www.virtualdub.org/beta/VirtualDub-....X-test9-src.7z
Two separate issues... the 0 bytes in the status window was a tiny buglet, while the VLC issue was something else. For the technically curious, the issue is that VideoLAN doesn't interpret dwSampleSize in an audio stream the same way as DirectShow -- it interprets it the "pure" way as dwSampleSize=0 means VBR, whereas Microsoft's AVI parsers always ignore dwSampleSize for audio streams. I was setting it to nBlockAlign, and changing that to 0 fixed the incompatibility. Not really optimal for the VLC guys to have their player interpreting that field differently than DirectShow, though.
I also fixed the cropping display issue, which was related to cropping with YCbCr input, but vertical cropping is still broken in that case and I need to take a look at that. I'm more worried by the realization that the input format can invisibly affect the cropping -- if you're in YV12 it can still crop, but only to 2x2 precision. I wonder if I should have an option to force a finely croppable format (RGB32 or 4:4:4 YCbCr) or have a visible warning on the crop dialog.
|
|
| Barough |
| Posted: Dec 31 2007, 10:44 AM |
|
|
Advanced Member
Group: Members
Posts: 95
Member No.: 22677
Joined: 24-December 07
|
Just had a quick test of the new Build and it works gr8 now. Thnx 
--------------------
|
|
| blob2500 |
| Posted: Dec 31 2007, 12:50 PM |
|
|
Member
Group: Members
Posts: 24
Member No.: 22015
Joined: 28-August 07
|
Thanks phaeron for this fix. AVI with VBR didn't work on my standalone dvd player if dwSampleSize is not "0". It works now |
|
| kewl |
| Posted: Jan 1 2008, 01:23 AM |
|
|
Newbie
Group: Members
Posts: 3
Member No.: 22726
Joined: 31-December 07
|
What is striking is that everything is developed by yourself with no call to 3rd party code.
Phaeron thanks for this great improvements and congrats!
This post has been edited by kewl on Jan 1 2008, 01:24 AM |
|
| Barough |
 Posted: Jan 2 2008, 06:36 AM |
|
|
Advanced Member
Group: Members
Posts: 95
Member No.: 22677
Joined: 24-December 07
|
@ phaeron
Do u think it will be long b4 we see a new stable release?
--------------------
|
|
| phaeron |
| Posted: Jan 2 2008, 10:17 PM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
Well, that's an interesting question.
1.7.8 only has two fixes queued up at the moment, both of which are for capture mode. One of them is fairly big (memory corruption after error), but not really enough for me to push out at the moment. 1.7.X is basically feature-complete at the moment, but I couldn't push that out as stable. So, basically, right now it looks like 1.7.X will become either 1.7.8/experimental or 1.8.0/experimental (probably the latter, given how much has gone into it). 1.8.1 would then be the first opportunity for 1.7.X features to hit a stable branch.
What do people here think? Anyone still seeing new bugs in 1.7.X they want squashed?
|
|
| Barough |
| Posted: Jan 3 2008, 02:56 AM |
|
|
Advanced Member
Group: Members
Posts: 95
Member No.: 22677
Joined: 24-December 07
|
Thnx for your reply.
With all the new features in it so does a v1.8.0/Experimental Release sounds best me @ the current time. So my vote is that v1.8.1 will be a Stable release.
--------------------
|
|
| squid_80 |
| Posted: Jan 3 2008, 03:23 AM |
|
|
Advanced Member
Group: Members
Posts: 594
Member No.: 13813
Joined: 22-January 05
|
| QUOTE (phaeron @ Jan 3 2008, 08:17 AM) | | What do people here think? Anyone still seeing new bugs in 1.7.X they want squashed? |
The cropping dialog still doesn't like framerate changes. Also it doesn't respect timeline edits, which is a bit of a pain. |
|
| phaeron |
| Posted: Jan 3 2008, 05:28 AM |
|
|
Virtualdub Developer
Group: Administrator
Posts: 7773
Member No.: 61
Joined: 30-July 02
|
http://www.virtualdub.org/beta/VirtualDub-....7.X-test10.zip
http://www.virtualdub.org/beta/VirtualDub-...est10-AMD64.zip
http://www.virtualdub.org/beta/VirtualDub-...X-test10-src.7z
Fixes the vertical YCbCr cropping bug and framerate related issues in the cropping dialog. Still doesn't respect timeline edits, but I might have to push on that one -- it's not easy to fix, since in order to do so I have to attempt to propagate the edit list backwards to the beginning of the filter entry, taking account any frame rate changes in between... ugh.
|
|
