|
|
| Serge |
| Posted: Jul 20 2010, 06:48 AM |
 |
|
Member
Group: Members
Posts: 12
Member No.: 28048
Joined: 18-July 10
|
| QUOTE (fredgiblet @ Jul 20 2010, 06:36 AM) | "Is there any Perforce access for contributors?"
I don't know what that means, sorry.
"I mean, if this is an open source project, what is a point of opening them without giving people a chance to contribute?"
So that other people can make their own modifications. Before phaeron implements the plugins system FccHandler created VirtualDub-MPEG2, which had his MPEG-2 decoding patch in it (now with the plugin capabilities FccHandler just makes the plugins), there's a fork called VirtualDubMod which added tons of abilities that's sadly been dead for almost half a decade now, there was a version called nanDub which offered better compression with DivX 3.11 and I think I remember a version called ASFdub or something that was supposed to re-add support for ASF. |
I meant access to the source control. It seems they are using Perforce there.
But anyways, you already answered my question. It is actually pity that lots of useful changes spread around in "clones" rather than becoming merged into a single root.
After talking to phaeron it seems I am going to re-implement this as a filter. Will update the community once it is done. |
|
| stephanV |
| Posted: Jul 20 2010, 06:49 AM |
|
|
Spam killer ;)
Group: Moderators
Posts: 4348
Member No.: 8917
Joined: 18-February 04
|
| QUOTE (Serge @ Jul 20 2010, 07:27 AM) | | MPEG2 HD is using 16x16 macroblocks, each of them is split on four 8x8 blocks, so that 1080 is divisible by 8. DivX in turn does not allow to split its 16x16 macroblocks. I guess, it is a point of discussion - whether to enforce 16- or 8-divisible size formats or just leave it free in this solution. |
DivX accepts mod4 widths and mod2 heights. Encoders normally pad internally and remove this on decoding, so I wouldn't put in any restrictions that codecs don't always have themselves.
--------------------
useful links:
VirtualDub, Input plugins and filters, AviSynth, AVI-Mux GUI, AC3ACM by fcchandler, VirtualDub FAQ |
|
| Serge |
| Posted: Jul 22 2010, 12:35 AM |
|
|
Member
Group: Members
Posts: 12
Member No.: 28048
Joined: 18-July 10
|
| QUOTE (stephanV @ Jul 20 2010, 06:49 AM) | | QUOTE (Serge @ Jul 20 2010, 07:27 AM) | | MPEG2 HD is using 16x16 macroblocks, each of them is split on four 8x8 blocks, so that 1080 is divisible by 8. DivX in turn does not allow to split its 16x16 macroblocks. I guess, it is a point of discussion - whether to enforce 16- or 8-divisible size formats or just leave it free in this solution. |
DivX accepts mod4 widths and mod2 heights. Encoders normally pad internally and remove this on decoding, so I wouldn't put in any restrictions that codecs don't always have themselves. |
I will drop the restriction in the final version that will be implemented as a video filter. |
|
| rjisinspired |
| Posted: Aug 15 2010, 12:20 PM |
|
|
Advanced Member
Group: Members
Posts: 1256
Member No.: 20008
Joined: 12-October 06
|
I might be being thick again but I went to test out the cropper in the patched version of Vdub and I couldn't get the crop area to move, believe it was a right-click and move?
I then went to import the roof sample because I remember being able to move the crop area around. I then loaded in the vcf file from the sample and received a SetClipping error, Line 1 column 66, overload method SetClipping not found?
What am I doing wrong? |
|
| Serge |
| Posted: Aug 19 2010, 01:42 AM |
|
|
Member
Group: Members
Posts: 12
Member No.: 28048
Joined: 18-July 10
|
| QUOTE (rjisinspired @ Aug 15 2010, 12:20 PM) | I might be being thick again but I went to test out the cropper in the patched version of Vdub and I couldn't get the crop area to move, believe it was a right-click and move?
I then went to import the roof sample because I remember being able to move the crop area around. I then loaded in the vcf file from the sample and received a SetClipping error, Line 1 column 66, overload method SetClipping not found?
What am I doing wrong? |
I am certain you are not running a patched version, but a regular one. Loading the vcf from the sample would only give this error with non-patched VirtualDub.exe. Same about moving the crop area, but keep in mind it is moved the same way as stretched (dragging by side or corner), just with right mouse button instead of left. I would suggest you download and unzip the archive into an empty directory freshly to avoid mix-ups. |
|
| rjisinspired |
| Posted: Aug 19 2010, 04:03 PM |
|
|
Advanced Member
Group: Members
Posts: 1256
Member No.: 20008
Joined: 12-October 06
|
Great. I have this working now with the moving of the box with the right-mouse. Thanks.
I'm assuming that since the cropping area is in a 840 X 480 rectangle within a 1280 X 720 video that I would have to resample to 848 X 480 to make the video come out as 848 X 480 and not upscale back to 1280 X 720. Am I correct with thinking this way?
I can see the effect of the cropper when in the cropper itself but as I preview the filtered video, the crop area is either offset or doesn't work which lead me to change the resample to the full 1280 X 720 size but then there is no dynamic cropping effect at all.
I must be missing something? |
|
| Serge |
| Posted: Aug 30 2010, 02:12 AM |
|
|
Member
Group: Members
Posts: 12
Member No.: 28048
Joined: 18-July 10
|
| QUOTE (rjisinspired @ Aug 19 2010, 04:03 PM) | Great. I have this working now with the moving of the box with the right-mouse. Thanks.
I'm assuming that since the cropping area is in a 840 X 480 rectangle within a 1280 X 720 video that I would have to resample to 848 X 480 to make the video come out as 848 X 480 and not upscale back to 1280 X 720. Am I correct with thinking this way?
I can see the effect of the cropper when in the cropper itself but as I preview the filtered video, the crop area is either offset or doesn't work which lead me to change the resample to the full 1280 X 720 size but then there is no dynamic cropping effect at all.
I must be missing something? |
I tried to play with some 1280 x 720 videos, it took me a while to get them displayed in VirtualDub first. At the end, I found a page (http://www.mrbluesummers.com/1410/3d-tutorials/downloading-viewing-and-editing-youtube-mp4-avc1/) that explained how to set up everything, and it seemed to be working. Now, I can reproduce the problem partially: in the cropper settings it works just fine, but in the preview I am getting an error: `The decompression codec cannot decompress to an RGB format. This is very unusual. Check that any "Force YUY2" options are not enabled in the codec's properties`.
What I think is, there maybe a similar problem with decompression to RGB in your case too, but it is a silent failure. I tried to disable all formats but RGB24, but did not succeed. I also tried a suggestion from http://www.teamliquid.net/forum/viewmessag...?topic_id=37562 , but it did not help too.
I will be trying to play with the Codec Tweak tool to adjust decompression settings. Will let you know when I get some results. |
|
| rjisinspired |
| Posted: Sep 2 2010, 02:49 PM |
|
|
Advanced Member
Group: Members
Posts: 1256
Member No.: 20008
Joined: 12-October 06
|
Thanks Serge.
I do remember getting that type of error once or twice in the past from FLV files:
http://forums.virtualdub.org/index.php?act...=15204&hl=force
I don't know how this applies to the cropper though? |
|
| Serge |
| Posted: Sep 11 2010, 02:00 AM |
|
|
Member
Group: Members
Posts: 12
Member No.: 28048
Joined: 18-July 10
|
OK, I could reproduce it with .FLV files and figured out how to solve the issue at least for now. There was a piece of code in the patch that was dealing with destruction of the preview pane that might happen on systems with slow CPUs (all references to mPixmapBuffer within FilterInstance class). Looks like, this code created the behavior you observed, so I decided to drop or #ifdef it. I made another build, please try -
http://www.codeproject.com/KB/miscctrl/dyn...patch-hdfix.zip
http://www.codeproject.com/KB/miscctrl/dyn...tched-hdfix.zip
If it works well, I make it final and put the corrected sources online. Please make sure ffdshow is set to decode to RGB32 or RGB24, other formats may not work with the cropper at the moment. All these limitations will be eventually addressed with a filter version of the cropper that I am planning to finalize in some near future.
Thanks! |
|
